Ticket #1029 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

articles published since 0.9-final upgrade have bad links in search

Reported by: russ Assigned to: rich
Priority: critical Milestone:
Component: ambra Version: 0.9-rc1
Keywords: search Cc:
Blocking: Blocked By:

Description

when an article is deleted and republished, something is broken in the lucene indexing.

as a result, the href on the search page is empty for repubbed articles.

example: 

http://www.plosone.org/search/simpleSearch.action?query=sandbox&x=0&y=0

i've repubbed the sandbox article (pone.000000) to test the article-state cache bugs that were fixed in 0.9-final.

the href for this article is empty, while the other article is okay.

in addition to fixing this bug, we'll need a way to reindex broken articles, perhaps we should resurrect jon's reIndex script?

Dependency Graph

Change History

(follow-up: ↓ 3 ) 09/19/08 11:06:47 changed by amit

  • milestone deleted.

The process Peter Jerram has requested needs to be followed. Please do not assign milestones directly here. It needs to be discussed so that everyone understands the impact.

09/19/08 11:14:43 changed by russ

examining the lucene index with Luke, i see the following differences between a repubbed article and a regular article:

property.contentModel = PLoSArticle for regular article, AmbraArticle? for repub property.label = XML Representation for regular article, PDF representation for repub

(in reply to: ↑ 1 ) 09/19/08 11:15:31 changed by russ

Replying to amit:

The process Peter Jerram has requested needs to be followed. Please do not assign milestones directly here. It needs to be discussed so that everyone understands the impact.

I haven't been informed of any process requested by peter jerram. Please provide documentation for this (perhaps the mailing list would be a better forum for discussions about process?)

09/19/08 11:18:50 changed by amit

Please talk to Rich about this.

09/22/08 11:16:23 changed by russ

  • summary changed from nasty search bug with republished articles to articles published since 0.9-final upgrade have bad links in search.

looks like this is happening for all articles pubbed since the 0.9-final upgrade.

checking config to see if there were any config changes that could be causing problems...

09/22/08 11:34:39 changed by russ

suspect this is related to the fedora.fcfg changes in r6238 and r6242

(follow-up: ↓ 8 ) 09/22/08 21:56:49 changed by ronald

Oh, I see the "bug": source:head/ambra/webapp/src/main/webapp/search/searchResults.ftl#6400 line 152. Dunno why that <#if> statement is there in the first place - can't we just take it out? Alternatively testing for both PLoSArticle and AmbraArticle should fix it.

(in reply to: ↑ 7 ; follow-up: ↓ 10 ) 09/22/08 22:40:16 changed by pradeep

Replying to ronald:

Oh, I see the "bug": source:head/ambra/webapp/src/main/webapp/search/searchResults.ftl#6400 line 152. Dunno why that <#if> statement is there in the first place - can't we just take it out? Alternatively testing for both PLoSArticle and AmbraArticle should fix it.

Ah! This is all the way from r1316. Should have been part of r6265. There is no need for that <#if>. All filtering is already done in the service classes.

09/22/08 23:23:32 changed by ronald

  • status changed from new to closed.
  • resolution set to fixed.

(In [6443]) Generate a link to the article for newer articles of type 'AmbraArticle?' too; this type was introduced in r6265, and hence this change should've been part of that one. This fixes #1029.

(in reply to: ↑ 8 ) 09/22/08 23:35:09 changed by ronald

Replying to pradeep:

Replying to ronald:

Oh, I see the "bug": source:head/ambra/webapp/src/main/webapp/search/searchResults.ftl#6400 line 152. Dunno why that <#if> statement is there in the first place - can't we just take it out? Alternatively testing for both PLoSArticle and AmbraArticle should fix it.

Ah! This is all the way from r1316. Should have been part of r6265. There is no need for that <#if>. All filtering is already done in the service classes.

Ok, removed the test completely in r6444.