Ticket #151 (closed task: fixed)

Opened 2 years ago

Last modified 1 year ago

Rename NoSuchIdExceptions & DuplicateIdExceptions to unique names

Reported by: ebrown Assigned to: ebrown
Priority: medium Milestone:
Component: topaz Version: 0.5-SNAPSHOT
Keywords: Cc:
Blocking: Blocked By:

Description

It is easy to confuse one NoSuchIdException with one in a different webservice or package. Agreed solution for now is to rename these to things like NoSuchArticleIdException, NoSuchAnnotationIdException, etc.

We've also discussed trying to have these all derive from a org.topazproject.common.NoSuchIdException for easier use, but that should probably be another ticket. It certainly requires a new topaz-common jar.

Dependency Graph

Change History

09/11/06 19:18:01 changed by ebrown

  • owner changed from somebody to ebrown.
  • status changed from new to assigned.
  • milestone changed from TBD to september24.

09/11/06 21:58:52 changed by amit

  • summary changed from Rename NoSuckIdExceptions & DuplicateIdExceptions to unique names to Rename NoSuchIdExceptions & DuplicateIdExceptions to unique names.

Corrected spelling.

09/14/06 21:28:36 changed by ebrown

(In [605]) Create vendor tree to patch java2wsdl maven plugin (re #151)

09/14/06 21:38:05 changed by ebrown

(In [606]) java2wsdl axistools-mavein-plugin patch (re #151)

  • Add classpath parameter to suplement classpath
  • Change groupId to org.topazproject.patch.plugin
  • Set deployment to gandalf

Note, at some point, classpath should really allow adding of dependencies instead of having to manually add path elements. It would be a lot more mavenesque.

09/14/06 22:57:57 changed by ebrown

(In [610]) Rename NoSuchIdExceptions? & DuplicateIdExceptions? (re #151)

  • Create base exceptions in topaz-common:
  • Use patched java2wsdl axistools-maven-plugin from [606]
    • Add built jars to java2wsdl classpath as appropriate in api packages
  • Rename exceptions in articles, annotations and users webservices
    • Added integration test to articles to ensure org.topazproject.common.NoSuchIdException? is shuttled across axis properly

09/14/06 23:05:48 changed by ebrown

(In [611]) Use org.topazproject.ws.users.NoSuchUserIdException? appropriately (re #151)

  • Removed extraneous NoSuchIdExceptions? that really should have been something from org.topazproject.ws.users all along (as far as I can tell)
  • Made api modules dependent on both topaz-common and ws-users-api

Checking this in separately from [610] as I'm marginally concerned about the ws-users-api dependency (to get org.topazproject.ws.users.NoSuchUsersIdException?). All integration tests succeed.

09/14/06 23:08:50 changed by ebrown

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [612]) Rename NoSuchIdException? and DuplicateIdException? to reduce confusion (fixes #151)

Integration tests failed with strange error message if I tried to extend the exceptions I added to topaz-common, so all I've done here is rename the exceptions to minimze confusion. Should consider better understanding the problem at some point in the future and inherit from base exceptions.

09/15/06 00:39:09 changed by ebrown

(In [613]) re #151 Update plosone code with topaz API changes

09/20/06 10:18:08 changed by ebrown

(In [642]) re #151 & #169 Use ${settings.localRepository} instead of ${user.home}/.m2/repository

This is certainly a problem for building on windows -- and a better way in general to reference files in the local repository. (Though I'm not sure yet if this fixes current windows build issues or not.)

10/29/07 21:13:03 changed by

  • milestone deleted.

Milestone september24 deleted