Ticket #283 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

Every module must contain version information (no inheritance possible) - CodehausJira:MNG-624

Reported by: ebrown Assigned to: ebrown
Priority: unassigned Milestone:
Component: maven Version:
Keywords: maven Cc:
Blocking: Blocked By:

Description

Note that this issue creates very annoying svn logs in all our pom.xml files. It complicates the release process and is aesthetically very annoying.

See CodehausJira:MNG-624. Many good ideas. Hopefully Brett can get off is butt and make a decision. Recommend implementing a patch off of one of these ideas though.

Also see CodehausJira:MNG-521 for how/why it is screwed up in the 2.0.x

Dependency Graph

Change History

02/19/07 01:27:16 changed by ebrown

  • status changed from new to closed.
  • resolution set to fixed.

(In [2358]) fixes #283 Version information can now be put in one property

The stipulation is that you must either have the entire tree (checked out) on disk (though you can build from anywhere) OR, if trying to build a sub- module, if the entire tree is NOT on disk, then you must define the variable used as a system property (-D on the command line).

There is certainly a smallish opportunity here to get totally messed up. Say if you used svn switch within modules between branches, etc. But the behavior is still probably rathe consistent.

Before posting to codehaus, I may briefly look at a few other issues:

  • What I'm doing for <version> should easily translate to <groupId> and <artifactId> and the code may look more consistent supporting these too.
  • It is not much more of a stretch to allow <parent><version> to be completely optional. That would be even cleaner and more obvious, but it isn't clear if this is 30-minutes or 3-hours of work.

(Most of this checkin is tests - as I needed them and the maven team is fairly anal about them if they're to accept a patch. The only interesting code is in DefaultMavenProjectBuilder?.java.)

02/20/07 10:44:06 changed by ebrown

(In [2364]) re #283 Remove need for anything in <parent> (instead infer when necessary)

Same caveats apply as [2358].

Now, if your parent-pom is in the directory above, all you need to specify is <parent/> to indicate that you have a parent and everything else will be filled in. If any inconsistencies are found, exceptions are thrown as would be expected.

This effectively fixes CodehausJira:MNG-624 as there is no further improvement I can see here.

08/07/07 16:25:51 changed by

  • milestone deleted.

Milestone Bugs deleted