Ticket #412 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

link href's in feed are not absolute

Reported by: russ Assigned to: jsuttor
Priority: high Milestone:
Component: ambra Version: 0.7
Keywords: feed Cc:
Blocking: Blocked By:

Description

<link rel="alternate" href="/article/fetchArticle.action?articleURI=info:doi/10.1371/journal.pone.0000326" />

is there a setting a missed in one of the config files, or is this by design?

thanks!

Dependency Graph

Change History

06/20/07 14:03:47 changed by stevec

  • owner changed from stevec to jsuttor.

06/20/07 14:12:22 changed by amit

Please assign feed problem to Jeff. Thanks.

06/20/07 14:34:14 changed by jsuttor

  • status changed from new to assigned.

this was intentional. the idea is that relative is better than absolute unless proven otherwise. note that web browsers, programs, etc. will all provide host:port:etc as needed.

06/20/07 15:15:32 changed by amit

  • status changed from assigned to new.

06/20/07 15:46:02 changed by jsuttor

  • status changed from new to closed.
  • resolution set to fixed.

06/20/07 16:44:36 changed by russ

  • status changed from closed to reopened.
  • type changed from clarification to defect.
  • resolution deleted.

except that, in a reader, the relative links don't necessarily work.

for example, i'm testing with feed reader (http://www.feedreader.com/) and i get relative links to nowhere.

i don't see anything in a brief scan of the atom spec that allows relative URLs in <link> href attributes, and all the examples given are absolute URLs.

06/20/07 19:21:08 changed by amit

Hmmm...something strange is going on here. This is what I see in #388:

<link rel="alternate" href="http://localhost:8080/article/fetchArticle.action?articleURI=info:doi/10.1371/journal.pone.0000310" />

So something changed.

06/21/07 02:43:43 changed by jsuttor

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [2973]) fixes #412 adds xml:base to <feed> document root, make representation links, PDF, XML, "related" to work w/more feed readers

06/27/07 11:15:27 changed by ebrown

(In [3030]) Merged revisions 2948-3028 via svnmerge from http://gandalf.topazproject.org/svn/branches/0.7

........

r2956 | jsuttor | 2007-06-19 20:35:06 -0700 (Tue, 19 Jun 2007) | 2 lines

fixes #397 Feed literals now come from common config.

........

r2967 | stevec | 2007-06-20 15:01:22 -0700 (Wed, 20 Jun 2007) | 7 lines

Fix browse service so that it is session scoped. This may (in part) be the cause of #383. Note that this fix will not reset the user's session. If he was browsing the site and then something was published, he may not pick up that change until his session expires. This is not ideal, but at the moment, this is the safest fix for the branch. If this presents a big problem, I can also make a change to browse which will make it work as expected.

........

r2968 | amit | 2007-06-20 15:02:18 -0700 (Wed, 20 Jun 2007) | 1 line

Removed password. Sorry, Eric, I should have done this in 0.7 first. Hope this does not mess up the merge

........

r2969 | stevec | 2007-06-20 15:22:49 -0700 (Wed, 20 Jun 2007) | 3 lines

Revert change introduced in 2943. Combined with the change in [2967], this should make browse behave properly after articles are published.

........

r2973 | jsuttor | 2007-06-21 02:43:43 -0700 (Thu, 21 Jun 2007) | 2 lines

fixes #412 adds xml:base to <feed> document root, make representation links, PDF, XML, "related" to work w/more feed readers

........

r3026 | jsuttor | 2007-06-26 18:26:17 -0700 (Tue, 26 Jun 2007) | 4 lines

add link to ratings guidlines in dialog, per Rich & Susan

  • Susan to provide ratingGuidlines.action
  • directly modeled on flagging a discussion

........

r3027 | ebrown | 2007-06-27 01:11:04 -0700 (Wed, 27 Jun 2007) | 3 lines

Initialized merge tracking via "svnmerge" with revisions "1-2946" from http://gandalf.topazproject.org/svn/head

........

10/29/07 21:13:36 changed by

  • milestone deleted.

Milestone 0.7 deleted