Ticket #441 (closed defect: fixed)

Opened 1 year ago

Last modified 1 month ago

Replies content model needs fixing.

Reported by: amit Assigned to: pradeep
Priority: high Milestone: 0.9.1
Component: ambra Version: 0.7
Keywords: content-model replies Cc:
Blocking: Blocked By: 780

Description

Reply's need grant and revoke permission objects

Dependency Graph

Change History

07/20/07 10:12:21 changed by amit

  • milestone changed from Bugs to 0.9.

09/02/07 22:41:40 changed by

  • milestone deleted.

Milestone 0.9 deleted

03/19/08 17:00:40 changed by amit

  • owner changed from amit to ronald.
  • priority changed from high to critical.
  • milestone set to 0.9.0.

As part of model migration.

04/04/08 17:28:31 changed by ronald

This seems to involve the following:

  • additional permission checks
  • admin UI (copy-paste from annotations)
  • verify replies related pages function properly with "missing" replies
  • either create 'allow' permissions on reply creation and data-migration for existing replies, or assume allowed-unless-forbidden.

This doesn't seem to require a content-model change per se, unless the addition of permissions instances is considered a content-model change.

04/04/08 18:42:16 changed by amit

  • owner changed from ronald to pradeep.

04/04/08 18:51:42 changed by amit

  • priority changed from critical to high.
  • milestone deleted.

Requires UI changes in admin and hence out for now.

07/31/08 21:35:03 changed by amit

  • blocking changed.
  • blockedby changed.
  • milestone set to 0.9.1.

09/08/08 17:24:28 changed by dragisak

  • blockedby set to 780.

09/09/08 10:35:11 changed by amit

  • component changed from information-model to ambra.

10/27/08 12:52:34 changed by pradeep

  • status changed from new to closed.
  • resolution set to fixed.

(In [6606]) Fix up permissions for annotations and replies. Note that listAllReplies() will prune the tree if the caller does not have permission to view a node.

'replies:getReplyInfo' permission is granted as part of making a reply public. However currently this is permitted by permitted-anonymous-operations xacml policy rule (assuming default xacml rules).

The existing replies in the database does not have those grants and therefore require the permitted-anonymous-operations rule to permit this. To make things consistent, the 'replies:getReplyInfo' permission needs to be granted in the grants named-graph. Only then it is safe to remove the rule from permitted-anonymous-operations.

Note also that 'replies:deleteReply' permission is revoked as part of making the reply 'public'. This means with the default ambra policies only an admin will be able to delete the reply. The 'creator' can not delete it.

The existing replies in the database does not have those revokes and therefore can be deleted by the 'creator'. To make things consistent, the replies:deleteReply permission needs to be revoked in the revokes named-graph.

This closes #441.