Ticket #473 (closed defect: fixed)

Opened 1 year ago

Last modified 5 months ago

on article delete, remove files from /var/spool/plosone/ingested, move zip back to ingestion-queue

Reported by: russ Assigned to: russ
Priority: medium Milestone:
Component: topaz Version: 0.7
Keywords: article delete Cc:
Blocking: Blocked By:

Description

if files in ingested are not cleaned up, we see errors on reingest.

Dependency Graph

Change History

(follow-up: ↓ 3 ) 07/10/07 13:14:14 changed by ebrown

  • owner changed from pradeep to ebrown.
  • status changed from new to assigned.

Yes, delete needs to be changed to use the OTM too.

07/10/07 13:17:08 changed by amit

  • keywords set to article delete.
  • version set to 0.7.
  • milestone changed from Bugs to 0.8.

(in reply to: ↑ 1 ) 07/10/07 13:24:58 changed by ronald

Replying to ebrown:

Yes, delete needs to be changed to use the OTM too.

That is actually an orthogonal issue to this ticket since zip's are not part of the OTM managed items.

07/24/07 12:36:59 changed by ebrown

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [3253]) fixes #473 On article delete, clean up files in /var/spool/plosone

07/24/07 20:39:49 changed by ronald

Eric, I'm not sure this is closed - I was assuming the deletes were being done via the adminTop pages, not via the command-line script. Russ, can you confirm what method you are using to delete an article?

07/29/07 23:02:09 changed by amit

  • status changed from closed to reopened.
  • resolution deleted.

07/29/07 23:02:17 changed by amit

  • owner changed from ebrown to russ.
  • status changed from reopened to new.

(follow-up: ↓ 10 ) 07/31/07 23:53:56 changed by ebrown

Note: The admin UI does not let people delete articles that are already published AFAIK.

Anyway, I've implemented this for the UI on my system. But it is hanging (or delete is broken for some other reason)... have to spend some more time debugging.

08/01/07 09:55:16 changed by russ

  • status changed from new to closed.
  • resolution set to fixed.

eric was correct, this issue was about the article_delete command line script for deleting already published articles.

sorry for being vague.

(in reply to: ↑ 8 ) 08/01/07 10:15:02 changed by pradeep

Replying to ebrown:

Note: The admin UI does not let people delete articles that are already published AFAIK. Anyway, I've implemented this for the UI on my system. But it is hanging (or delete is broken for some other reason)... have to spend some more time debugging.

Make sure this is not a nested txn issue on Mulgara txns. OTM'ifying ArticleUtil?.delete() using a new SessionFactory? and Session and Transaction for delete can cause a dead-lock if the path leading to the delete() call had already started an Itql Txn. This will invariably happen because user-intercepter and xacml/permissions etc. could all have started a txn. (unless things are all cached). The xacml and permissions-impl use the same ItqlInterpreter? as the OTM Transaction - closing the underlying Itql txn if those were not previously open. So those are not likely to interfere. So the user-intercepter - when the user-id is not cached is a likely cause for dead-lock.

Note that the ItqlHelper? that is passed to ArticleUtil?.delete() in ArticleOtmService? is a shared handle with OTM. See ArticleOtmService?.java:218. A better fix would be to have the ArticleOtmService?.delete() take an OTM transaction instead of the ItqlHelper?. This way it can work with the Txn in PloseOne?-Webapp and also work with the Txn from the SessionFactory? created for the command-line usage.

08/07/07 15:29:30 changed by ebrown

(In [3348]) Fix some issues with article deletion (re #473)

  • Move logic from [3253] that moves files from ingestion queues to article-util so that files are moved from admin console too
  • Move transaction to API (fixes deadlock trying to delete from console)
  • Remove unused routines
  • Finish removing itql queries not used now that otm is used

07/16/08 11:00:34 changed by

  • milestone deleted.

Milestone 0.8 deleted