Ticket #570 (closed clarification: fixed)

Opened 1 year ago

Last modified 5 months ago

based on timing, the default (all articles) feed is not being cached

Reported by: russ Assigned to: ebrown
Priority: medium Milestone:
Component: ambra Version: 0.8
Keywords: feed cache Cc:
Blocking: Blocked By:

Description

i grabbed the main feed. it took ~10s to build. i hit it again, ~6s. on multiple subsequent hits, average was around 7s. 

2007-08-17 16:29:28,036 INFO  TimerInterceptor(PLoSONE)> Executed action [/article/feed/getFeed!execute] took 10014 ms. [TP-Processor1 com.opensymphony.xwork2.interceptor.TimerInterceptor]
2007-08-17 16:29:41,023 INFO  TimerInterceptor(PLoSONE)> Executed action [/article/feed/getFeed!execute] took 6175 ms. [TP-Processor3 com.opensymphony.xwork2.interceptor.TimerInterceptor]

i grabbed a category feed, it took ~7secs to build i hit it again, 86ms on multiple subsequent hits, average was around ~85ms 

2007-08-17 16:44:54,008 INFO  TimerInterceptor(PLoSONE)> Executed action [/article/feed/getFeed!execute] took 7794 ms. [TP-Processor5 com.opensymphony.xwork2.interceptor.TimerInterceptor]
2007-08-17 16:45:15,015 INFO  TimerInterceptor(PLoSONE)> Executed action [/article/feed/getFeed!execute] took 86 ms. [TP-Processor7 com.opensymphony.xwork2.interceptor.TimerInterceptor]

so it looks like the category feeds are being cached, but not the main feed...

Dependency Graph

Change History

08/17/07 16:51:47 changed by amit

  • owner changed from jsuttor to ebrown.
  • milestone set to 0.8.

08/21/07 09:46:53 changed by ebrown

  • status changed from new to closed.
  • resolution set to fixed.

(In [3536]) fixes #570 Fix timing on feed caches

The cache keys were being defined including the start-date. And the start- date was defined as 3-months prior to the current timestamp including hours, minutes and seconds. So, everytime a new feed was requested, the start-date was changing (unless the request was in the same second). To fix this, we now zero out the hours, minutes and seconds.

This fix also makes the number of months back configurable. (Jeff and I debated whether this should really be in days or weeks and decided to leave it in months for now.)

Add a bit of logging.

07/16/08 11:00:34 changed by

  • milestone deleted.

Milestone 0.8 deleted