Ticket #715 (reopened defect)

Opened 1 year ago

Last modified 11 months ago

group author name missing from citation download

Reported by: russ Assigned to: jkirton
Priority: medium Milestone:
Component: ambra Version: 0.8.1
Keywords: Cc:
Blocking: Blocked By:

Description

susanne reports:

For article: http://www.plosone.org/article/fetchArticle.action?articleURI=info:doi/10.1371/journal.pone.0000285

The group author (<collab> in XML markup) doesn't appear on the Download Citation page: http://www.plosone.org/article/citationList.action?articleURI=info%3Adoi%2F10.1371%2Fjournal.pone.0000285

nor does it appear on the RIS or BibTex? downloads from that page

Dependency Graph

Change History

01/03/08 13:21:56 changed by rich

  • owner changed from jsuttor to jkirton.
  • milestone set to pubApp_0.8.3.

Susanne can provide additional information if necessary.

01/07/08 14:21:20 changed by jkirton

  • status changed from new to closed.
  • resolution set to fixed.

(In [4461]) fixes #715 'group author name missing from citation download'

  • Modified citation.xsl to pick up desired collab tags in the article xml representing collaborative (group) authors.
  • Modified CitationInfo?.java to hold this additional data.
  • Modified bibtex.ftl and ris.ftl to display collaborative authors in the citation downloads

TODO: verify that we only want collab tags having the attribute: collab-type='authors' to filter through as article xml files that I've evidenced with collab tags DON'T have this attribute.

01/07/08 14:52:33 changed by amit

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone deleted.

Hmmm...this fix unfortunately builds on something that needs to be rewritten. I am reopening the ticket as this is part of the larger 'remodelling' issues.

01/07/08 14:58:40 changed by amit

  • status changed from reopened to closed.
  • resolution set to fixed.

Closing this as I have opened #742

01/07/08 17:48:03 changed by rich

  • milestone set to pubApp_0.8.3.

01/07/08 17:51:50 changed by jsuttor

(In [4476]) Merged revisions 4461 via svnmerge from http://gandalf.topazproject.org/svn/branches/0.8.2

........

r4461 | jkirton | 2008-01-07 14:21:20 -0800 (Mon, 07 Jan 2008) | 8 lines

fixes #715 'group author name missing from citation download'

  • Modified citation.xsl to pick up desired collab tags in the article xml representing collaborative (group) authors.
  • Modified CitationInfo?.java to hold this additional data.
  • Modified bibtex.ftl and ris.ftl to display collaborative authors in the citation downloads

TODO: verify that we only want collab tags having the attribute: collab-type='authors' to filter through as article xml files that I've evidenced with collab tags DON'T have this attribute.

........

01/07/08 18:26:04 changed by russ

  • status changed from closed to reopened.
  • resolution deleted.

i'm not seeing group authors in the citation downloads for pone articles e285 and e1254.

instead, i'm seeing an empty author where the group author should be.

10.1371%2Fjournal.pone.0001254.ris 

A1  - Conwit, Robin
A1  - Keller, Margaret A.
A1  - , 
Y1  - 2007/12/05

here's the XML from e1254 for the group author: 

<collab xlink:type="simple">for The ALS Research Group</collab>

in this case, there is no collab-type attribute, but we DO want this author afaik - but perhaps susanne gave you different information?

let me know if i'm missing something...either way we're good to go for 0.8.2...

01/07/08 18:29:19 changed by russ

oh, i see. there's a contrib-type="author" attribute in the containing contrib tag for the group author

again from e1254

regular author XML: 

<contrib contrib-type="author" xlink:type="simple"><name name-style="western"><surname>Gordon</surname><given-names>Paul H.</given-names></name><xref ref-type="aff" rid="aff3"><sup>3</sup></xref></contrib>

group author XML: 

<contrib contrib-type="author" xlink:type="simple"><collab xlink:type="simple">for The ALS Research Group</collab></contrib>

the difference being that the group author has a single <collab> element, instead of <name><given-names> etc...

01/21/08 09:49:03 changed by rich

  • milestone deleted.