Ticket #745 (new clarification)

Opened 11 months ago

Last modified 2 weeks ago

caching improvements for feeds

Reported by: russ Assigned to: wtoconnor
Priority: critical Milestone: 0.9.1
Component: ambra Version: 0.8.2-SNAPSHOT
Keywords: cache, atom, feed Cc:
Blocking: Blocked By:

Description

feeds should be cached permanently (or with a very long ttl)

feed cache should be flushed on the following events:

  • article publish
  • article delete
  • update of a virtual journal article collection

this will allow us to stop generating static feeds daily (which is currently a resource-intensive daily cron that always generates at least one nagios alert and occasionally hangs the stack)

Dependency Graph

Change History

01/08/08 09:30:21 changed by jsuttor

  • keywords set to cache, atom.
  • status changed from new to assigned.
  • milestone set to pubApp_0.8.3.

01/08/08 15:12:18 changed by rich

  • milestone changed from pubApp_0.8.3 to pubApp_0.8.2.1.

01/22/08 17:15:13 changed by russ

  • milestone deleted.

07/31/08 23:44:07 changed by amit

  • owner changed from jsuttor to russ.
  • status changed from assigned to new.
  • type changed from enhancement to clarification.
  • blocking changed.
  • blockedby changed.

Please confirm behaviour with 0.9.

08/05/08 09:56:33 changed by pradeep

  • milestone set to 0.9.1.

08/15/08 16:20:55 changed by russ

  • owner changed from russ to rich.

confirmed that feed entries are not invalidated ever.

however, with 0.9 and multi-transaction mulgara, it's not as big an issue.

09/03/08 12:19:49 changed by rich

  • keywords changed from cache, atom to cache, atom, feed.

09/08/08 15:57:55 changed by amit

  • owner changed from rich to pradeep.

09/08/08 15:59:58 changed by amit

  • type changed from clarification to task.

Feeds are being cached, but no listening for for listed event for invalidations.

09/08/08 16:15:42 changed by dragisak

  • owner changed from pradeep to dragisak.

09/08/08 16:57:59 changed by dragisak

  • priority changed from medium to critical.

09/25/08 16:15:00 changed by dragisak

(In [6460]) Invalidate feed cache on article publish and delete. Addresses #745.

09/26/08 14:27:49 changed by dragisak

(In [6466]) Invalidate feed cache on virtual journal changes. References #745

09/29/08 10:27:04 changed by dragisak

  • status changed from new to assigned.

09/30/08 11:27:01 changed by amit

  • owner changed from dragisak to russ.
  • status changed from assigned to new.
  • type changed from task to clarification.

(follow-up: ↓ 18 ) 11/05/08 17:10:16 changed by russ

looks like we're dumping all the keys in the cache on any publish or delete action, without respected the feed arguments.

i shouldn't invalidate the pone feed if i publish a pcbi article. i shouldn't invalidete the Biochemistry feed if i publish a Public Health article i shouldn't invalidate a feed with a specific date range, if i publish an article with a pub-date outside that range.

i'm not sure if the above changes are within the scope of this ticket - if not, let's open a new ticket and prioritize.

11/05/08 17:10:42 changed by russ

  • owner changed from russ to dragisak.

since we're now invalidating the feedCache automatically, ehcache.xml should set feedCache to eternal.

(in reply to: ↑ 16 ) 11/05/08 17:29:42 changed by amit

Replying to russ:

looks like we're dumping all the keys in the cache on any publish or delete action, without respected the feed arguments. i shouldn't invalidate the pone feed if i publish a pcbi article. i shouldn't invalidete the Biochemistry feed if i publish a Public Health article i shouldn't invalidate a feed with a specific date range, if i publish an article with a pub-date outside that range. i'm not sure if the above changes are within the scope of this ticket - if not, let's open a new ticket and prioritize.

Definitely not in scope for this ticket. Besides some of the above are not going to be obvious as the same article could belong to multiple journals and hence those feeds might need to be invalidated.

11/06/08 13:58:15 changed by russ

i'll open a new ticket for smarter invalidation. i think that what we've got in this ticket is an improvement in any case.

this ticket should stay open for ehcache.xml changes.

11/06/08 14:00:13 changed by russ

oops. we've added endDate to the cache key in cases when article/feed is called with no query string.

since endDate defaults to now, this means that no user will *ever* get the cached copy of the default feed, unless two users request the default feed in the same second.

please revert this.

11/06/08 14:01:12 changed by russ

confirmed the 0.9 does not include endDate in the cache key for the default feed.

11/06/08 14:05:06 changed by russ

i would argue for removing the start date from the cache key for the default feed as well.

11/10/08 14:12:34 changed by rich

  • owner changed from dragisak to wtoconnor.