Ticket #888 (closed defect: duplicate)

Opened 9 months ago

Last modified 7 months ago

Advanced Search not applying journal filter

Reported by: rich Assigned to:
Priority: critical Milestone:
Component: ambra Version: 0.8.2.1
Keywords: search Cc:
Blocking: Blocked By: 959

Description

Advanced search on PLoS Genetics for author "DeRisi?" gives results for a PLoS ONE and a PLoS Pathogens article. The URLs are built with PLoS Genetics domain name and article DOI.

http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.pone.0000094 http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.ppat.0020025

Dependency Graph

Attachments

search_advanced_form_v2.jpg (60.5 kB) - added by stoomey on 05/23/08 14:38:47.
Proposed addition of journal filter to Adv. Search. Note that the default selection in the pulldown would be deterimined by journal context.

Change History

04/01/08 13:55:41 changed by rich

  • summary changed from Advanced Search not applyting journal filter to Advanced Search not applying journal filter.

04/01/08 13:57:47 changed by rich

Note that in future versions of Advanced Search, we will give users the ability to search across journal boundaries.

04/01/08 16:09:13 changed by rich

  • milestone changed from pubApp_0.8.2.2 to 0.9.0.

04/02/08 11:12:48 changed by russ

it looks like the filter is not being invoked if the article is cached.

is it possible to add a journal parameter to the search itself, so that the filter is unecessary?

if this is easy, can we do for 0.8.2.2?

04/02/08 16:15:36 changed by jsuttor

(In [5263]) addresses #888, add journal to search

  • heavy-handed-work-around, not a fix
  • fix is to:
    • elevate Journal Filters to cache level services
    • cache actual Journal Filters for performance

#888 is being left open for real resolution in 0.9

04/03/08 18:16:53 changed by alex

(In [5348]) Merged revisions 5263 via svnmerge from http://gandalf.topazproject.org/svn/branches/0.8.2.2

........

r5263 | jsuttor | 2008-04-02 16:15:34 -0700 (Wed, 02 Apr 2008) | 7 lines

addresses #888, add journal to search

  • heavy-handed-work-around, not a fix
  • fix is to:
    • elevate Journal Filters to cache level services
    • cache actual Journal Filters for performance

#888 is being left open for real resolution in 0.9

........

05/05/08 15:01:36 changed by amit

  • owner changed from jsuttor to rich.
  • blocking changed.
  • blockedby changed.

I think we need to add 'Journals' as another filter for 'Advanced Search'. By default, within a journal, this field (in the Advanced Search page) should be set to that Journal. But the user should be able to override it to state 'All Journals'.

Transferring to Rich for further thought.

05/09/08 10:44:55 changed by rich

  • owner changed from rich to amit.

I agree but journal filters a problematic. Currently, the search result will add the article DOI to the existing base URL. So a ONE paper will appear in genetics e.g. http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.pone.0000094

The paper displays correctly (even with the "Published in PLoS ONE" text under the article banner) but figure links return

2008-05-09 10:33:51,834 WARN  SecondaryObjectAction(PLoSGenetics)> Couldn't retrieve secondary object for URI: info :doi/10.1371/journal.pone.0000094 [TP-Processor2626 org.plos.article.action.SecondaryObjectAction]
org.plos.article.util.NoSuchArticleIdException: (id = 'info:doi/10.1371/journal.pone.0000094')

This needs to be corrected before the Journal drop down can be added to the Advanced Search form.

05/09/08 12:03:29 changed by amit

  • owner changed from amit to rich.

Shouldn't this be getting always redirected to the DOI Resolver?

05/09/08 12:04:22 changed by amit

Sorry, I meant the URL there should always be that of the DOI Resolver so it then redirects it back to the correct journal.

05/09/08 16:37:33 changed by rich

  • owner changed from rich to amit.

Sounds like the correct way to handle the URLs.

05/14/08 17:02:49 changed by amit

  • owner changed from amit to alex.

Assigning to Alex...

05/23/08 14:38:47 changed by stoomey

  • attachment search_advanced_form_v2.jpg added.

Proposed addition of journal filter to Adv. Search. Note that the default selection in the pulldown would be deterimined by journal context.

05/27/08 14:13:40 changed by amit

  • owner changed from alex to jkirton.

Assigning to Jon.

05/30/08 08:57:30 changed by jkirton

  • status changed from new to assigned.

06/06/08 07:39:22 changed by amit

  • owner changed from jkirton to amit.
  • status changed from assigned to new.

06/09/08 16:20:36 changed by amit

  • status changed from new to assigned.

06/14/08 14:33:30 changed by amit

  • priority changed from critical to low.
  • blockedby set to 959.

06/17/08 15:39:17 changed by amit

  • priority changed from low to high.

06/17/08 19:57:13 changed by amit

(In [5989]) Replaced the link in the search result page to point to the doi resolver. This is a hack till search is fixed to return results not requiring something else to (doi resolver) to fix the problem. Addresses #888

NOTE: Could someone please eyeball the lines I deleted as I think there was an extra </span> there?

06/17/08 19:58:16 changed by amit

  • owner deleted.
  • priority changed from high to critical.
  • status changed from assigned to new.
  • milestone deleted.

While we might have addressed the immediate need for 0.9, we really need to fix this properly. Increasing priority and moving it out of 0.9.

06/23/08 15:49:14 changed by amit

  • status changed from new to closed.
  • resolution set to duplicate.

Duplicate of #744.