Ticket #956 (closed defect: fixed)

Opened 5 months ago

Last modified 4 months ago

plos doi prefix is hardcoded

Reported by: russ Assigned to: pradeep
Priority: high Milestone: 0.9.0
Component: ambra Version: 0.9-SNAPSHOT
Keywords: Cc:
Blocking: Blocked By:

Description

end users need to be able to configure their own doi prefixes.

do we require that all users of ambra have a doi prefix?

perhaps end users need to be able to configure a regex for their article (and other) URIs generally so that users who are not members of crossref to create unique URIs for their ambra installation.

Dependency Graph

Change History

06/09/08 19:22:16 changed by amit

  • status changed from new to closed.
  • resolution set to duplicate.

Duplicate of #952.

06/11/08 09:06:25 changed by russ

  • status changed from closed to reopened.
  • resolution deleted.

no. this is not a dupe of #952.

#952 is about the doi resolver url - http://dx.doi.org

this is about PLoS's doi user prefix - doi/10.1371

doi user prefixes are organization specific. PLoS is allowed to create any doi beginning with 10.1371. no one else is.

thus this MUST be configurable by 0.9 release.

we also need to decide if being a crossref member (which is how you get a doi prefix) is a requirement of using ambra, or if we'll allow some other way to create URIs for non-member.

06/11/08 09:24:47 changed by amit

  • priority changed from critical to low.

Right. Sorry, I misread. 10.1371 is hard-coded in quite a few places and yes, that will need to be changed before release but is not needed for push to production. Right now we are marking tickets 'critical' needed to get a version of 0.9 on the PLoS production machines.

06/12/08 10:03:42 changed by russ

absolutely! sorry for not checking/changing the priority...

06/23/08 14:32:12 changed by amit

  • owner changed from amit to pradeep.
  • priority changed from low to medium.
  • status changed from reopened to new.

Can you start removing some of the hard coding as a background task?

06/26/08 13:44:36 changed by pradeep

  • status changed from new to closed.
  • resolution set to fixed.

(In [6077]) Remove hard-coded info:doi/10.1371. Instead configure aliases in ambra.aliases.*. The alias 'id:' is used in the otm-models lib. This closes #956.

06/26/08 17:26:39 changed by pradeep

  • status changed from closed to reopened.
  • resolution deleted.

06/26/08 17:28:57 changed by pradeep

There are some more not too obvious ones. So will keep it open till we test it out with another id prefix. From Ronald: 

There are also a couple more hidden places where doi's are assumed:
SearchUtil.objIdToFedoraPid and RepresentationFedoraBlobFactory.toPID
are two that immediately come to mind. Of course the sip-preparation
also has some assumptions here, but that's probably ok as it's
somewhat PLoS specific.

06/26/08 17:32:44 changed by amit

  • priority changed from medium to low.

07/01/08 16:00:25 changed by russ

note that prepare_sip also needs to have a configurable doi prefix for this milestone.

07/17/08 13:37:05 changed by amit

  • owner changed from pradeep to ronald.
  • priority changed from low to high.
  • status changed from reopened to new.

08/01/08 17:24:30 changed by amit

  • owner changed from ronald to pradeep.

Pradeep, assigning this to you.

08/04/08 18:09:42 changed by pradeep

  • status changed from new to assigned.

The list of files that have assumptions about 'info:doi' as the prefix for the article-id: 

./libs/otm-models/src/main/java/org/topazproject/ambra/models/support/fedora/RepresentationFedoraBlobFactory.java
./doi-resolver/src/main/java/org/topazproject/ambra/doi/ResolverServlet.java
./webapp/src/main/java/org/topazproject/ambra/article/service/SearchUtil.java
./webapp/src/main/java/org/topazproject/ambra/util/CitationUtils.java

Additional assumptions:

  • fedora pids have 'doi:' prefix
  • assumptions on figure dois in ResolverServlet
  • documentPrefix assumption in DocumentManagementService (in applicationContext.xml)

08/05/08 18:11:01 changed by pradeep

(In [6304]) Make all the id prefixes (info:doi/, info:fedora/) and Fedora PID namespace (PLoS, Ambra, doi) configurable. The configuration changes are under ambra.aliases and under ambra.topaz.blobStore.fedora.

This addresses #956.

08/05/08 18:24:43 changed by pradeep

(In [6305]) Remove the assumption about the figure-regexps. Get it from the config.

Addresses #956.

08/05/08 18:26:03 changed by pradeep

  • status changed from assigned to closed.
  • resolution set to fixed.

Think I have caught all the various assumptions about ids. Closing this.