Ticket #994 (closed defect: worksforme)

Opened 6 months ago

Last modified 5 months ago

Error in search/searchResults.ftl

Reported by: rich Assigned to: russ
Priority: medium Milestone: 0.9.0
Component: ambra Version: 0.9-rc1
Keywords: Cc:
Blocking: Blocked By:

Description 

2008-07-21 01:21:27,449 ERROR runtime(PLoSCompBiol)>  [TP-Processor194 freemarker.runtime]
Expression query is undefined on line 70, column 45 in search/searchResults.ftl.
The problematic instruction:
----------
==> ${query?html} [on line 70, column 43 in search/searchResults.ftl]
 in include "${templateFile}" [on line 31, column 1 in journals/plosJournals/templates/main_template.ftl]
----------

Java backtrace for programmers:
----------
freemarker.core.InvalidReferenceException: Expression query is undefined on line 70, column 45 in search/searchResu
lts.ftl.
        at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124)
        at freemarker.core.Expression.getStringValue(Expression.java:118)
        at freemarker.core.Expression.getStringValue(Expression.java:93)
        at freemarker.core.StringBuiltins$StringBuiltIn._getAsTemplateModel(StringBuiltins.java:71)
        at freemarker.core.Expression.getAsTemplateModel(Expression.java:89)
        at freemarker.core.Expression.getStringValue(Expression.java:93)
        at freemarker.core.DollarVariable.accept(DollarVariable.java:76)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.MixedContent.accept(MixedContent.java:92)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.IfBlock.accept(IfBlock.java:82)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.MixedContent.accept(MixedContent.java:92)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.Environment.include(Environment.java:1477)
        at freemarker.core.Include.accept(Include.java:169)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.MixedContent.accept(MixedContent.java:92)
        at freemarker.core.Environment.visit(Environment.java:208)
        at freemarker.core.Environment.process(Environment.java:188)
        at freemarker.template.Template.process(Template.java:237)
        at org.apache.struts2.views.freemarker.FreemarkerResult.doExecute(FreemarkerResult.java:168)
        at org.apache.struts2.dispatcher.StrutsResultSupport.execute(StrutsResultSupport.java:178)
        at com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:348)
        at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:253)
        at org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:50)
        at org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:504)
        at org.apache.struts2.dispatcher.FilterDispatcher.doFilter(FilterDispatcher.java:419)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
        at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:129)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.plos.web.DummySSOFilter.doFilter(DummySSOFilter.java:105)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.plos.web.VirtualJournalContextFilter.doFilter(VirtualJournalContextFilter.java:163)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:164)
        at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:141)
        at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:90)
        at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:406)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.plos.web.MultipleRequestFilter.doFilter(MultipleRequestFilter.java:95)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
        at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:200)
        at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:283)
        at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:773)
        at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:703)
        at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:895)
        at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
        at java.lang.Thread.run(Thread.java:595)

Dependency Graph

Change History

07/23/08 13:40:06 changed by rich

  • component changed from topaz to ambra.

07/23/08 14:30:11 changed by rich

  • priority changed from unassigned to medium.

07/26/08 21:57:32 changed by amit

  • milestone deleted.

Not for 0.9.

07/30/08 16:02:13 changed by amit

  • milestone set to 0.9.0.

07/31/08 14:16:01 changed by jkirton

  • status changed from new to assigned.

I can't re-produce. Are there specific steps that were taken?

08/01/08 11:01:51 changed by jkirton

  • owner changed from jkirton to russ.
  • status changed from assigned to new.

Per Russ, I am giving this to him to see if he can correlate this to anything significant in the apache/production logs as he can't re-produce this either. Maybe this is induced by a crawler that represents bad input that isn't possible by normal user interaction?

08/06/08 12:01:51 changed by rich

I correlated some search error with simpleSearch.action in the Apache logs from a single IP address. I don't see anything other than an old browser. 

58.251.59.5 - - [05/Aug/2008:10:38:32 -0700] "GET /static/reviewerGuidelines.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14990 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:32 -0700] "GET /static/information.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14955 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:32 -0700] "GET /static/ratingGuidelines.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14980 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla /4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:32 -0700] "GET /search/simpleSearch.action HTTP/1.1" 200 14893 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /static/policies.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14940 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /static/reviewerGuidelines.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14990 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /search/simpleSearch.action HTTP/1.1" 200 14893 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /static/policies.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14940 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /static/reviewerGuidelines.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14990 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /search/simpleSearch.action HTTP/1.1" 200 14893 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

58.251.59.5 - - [05/Aug/2008:10:38:33 -0700] "GET /static/policies.action;jsessionid=076FD29D3FF21032D4B3FD71DB64CD4F HTTP/1.1" 200 14940 "http://www.ploscompbiol.org/article/info:doi/10.1371/journal.pcbi.0040020" "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)"

08/12/08 13:59:22 changed by russ

from httpd logs: 

212.116.219.54 - - [21/Jul/2008:01:21:27 -0700] "GET /search/simpleSearch.action HTTP/1.1" 200 3116 "-" "WebCopier v4.4"

08/12/08 14:01:48 changed by russ

  • status changed from new to closed.
  • resolution set to worksforme.

even better 

212.116.219.54 - - [21/Jul/2008:01:21:27 -0700] "GET /search/simpleSearch.action HTTP/1.1" 200 3116 "-" "WebCopier v4.4"
212.116.219.54 - - [21/Jul/2008:01:21:28 -0700] "GET /search/advancedSearch.action HTTP/1.1" 200 6538 "-" "WebCopier v4.4"

so i think we can conclude this is a bot interaction and not a live interaction.